60 replies to this topic

[Alienizer]

rouncer, on 22 May 2012 - 09:24 AM, said:

hey alienizer, nice work there, thanks for the input.
could you explain tone mapping to me? im not familiar with the term!

http://expf.wordpres...pping_operator/

The one from Geon is a must as well.

[Reedbeta]

IMO the best tonemapping algorithm for games currently is Jim Hejl's curve, as reported in John Hable's talk about Uncharted 2. The equation is on slide 140 of this presentation. It's quite simple and has no adjustable parameters (you for sure want to incorporate an adjustable exposure and maybe contrast before applying this equation), but it looks very nice, especially once you have a proper HDR value range in your scenes. BTW, that whole presentation is well worth a read; it's a very good general introduction to the issues of gamma correction, linear-color-space lighting, HDR and tonemapping...every graphics programmer should know these things.

[Alienizer]

hmmm, I used the code on page 137 and everything is light gray with a bit of shades!!?? looks like a bad ambient occlussion. Seems to simple the code, am I missing something?

[Reedbeta]

I said page 140, not 137. The stuff from page 137 was an older version that used lookup textures that you have to initialize with some filmic curve. Just apply the equation from 140 (to each RGB channel independently). Again, that must be applied to linear HDR color values after scaling by exposure. And it incorporates the linear-to-gamma conversion, so it generates an sRGB output color.

[Alienizer]

Indeed you said 140, but stupid me I had to stop at the first equation page

I don't understand the LinearColor-0.004 thing. I mean, does LinearColor is the actual color output from the render, or does it need to be LinearColor = Color/(Color+1) or something?

[rouncer]

better? (note theres no tone mapping, just adjusted light levels.)

[Alienizer]

YES, much better! Now the sun starts to feel HOT
A little brighter maybe?

[Reedbeta]

LinearColor is just the linear-color-space, HDR color value output from the renderer.

[rouncer]

too bright?

[rouncer]

this seems to be the happy medium.

[rouncer]

more modelling...

[rouncer]

this areas done...

[Stainless]

That looks 100% right to me

[rouncer]

thanks Stainless!
just to polish it off, tiny little bumps on the surface.

[Alienizer]

Looks perfect to me now. Great job on the lighting! First one, yes, too bright.

[Alienizer]

Reedbeta, on 24 May 2012 - 04:54 AM, said:

LinearColor is just the linear-color-space, HDR color value output from the renderer.

ok, so the equation wants LinearColor, not the color from the render. So how does this work then??

[rouncer]

thanks alienizer, getting the balance between the ambient light and the direct light seems to be the trick.

[Alienizer]

rouncer, on 24 May 2012 - 02:29 PM, said:

thanks alienizer, getting the balance between the ambient light and the direct light seems to be the trick.

It looks fantastic now. I can just imagine when you'll put some monsters and stuff, and a background how nice it'll look! Are you working on a game or just for pleasure?

[Reedbeta]

Alienizer, on 24 May 2012 - 02:12 PM, said:

ok, so the equation wants LinearColor, not the color from the render. So how does this work then??

Read the rest of that presentation.

[Alienizer]

Reedbeta, on 24 May 2012 - 04:47 PM, said:

Read the rest of that presentation.

I did, but it still isn't looking right, everything is dull. I just don't understand it. I even tried the codes from http://filmicgames.com/archives/75 and still isn't right. My render material colors are between o and 1, but lights hiting a surface will go way above 1, so the final render data is >= 0 <=(all lights power added up) Could that be the problem?